Execution Tests: Long Vector - Dot fp32 precision #7801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damyanp
approved these changes
Oct 7, 2025
Comment on lines
+1052
to
+1053
| // Accumulate in fp32 to improve precision. | ||
| float DotProduct = 0.0f; |
There was a problem hiding this comment.
I think there's more a story to this than just wanting to improve precision in the tests? Doesn't this mean we likely need to clarify something in the spec?
There was a problem hiding this comment.
Yeah, I think we should clarify. I wasn't sure exactly where that clarification belongs though. Will follow up on that discussion with the team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Dot expected values to be computed with fp32 precision.